summaryrefslogtreecommitdiffstats
path: root/drivers/input
diff options
context:
space:
mode:
authorFerruh Yigit <fery@cypress.com>2013-05-23 09:56:55 -0700
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2013-06-05 22:46:30 -0700
commitd2983cdb480157f637df07723f28aaa657b1080d (patch)
treecf6c7038a85a31bf079747b48d540144462f93f3 /drivers/input
parent3bd1f7e2db4124a2726f9afdeaaf82f09b0bd8eb (diff)
downloadop-kernel-dev-d2983cdb480157f637df07723f28aaa657b1080d.zip
op-kernel-dev-d2983cdb480157f637df07723f28aaa657b1080d.tar.gz
Input: cyttsp - fix memcpy size param
memcpy param is wrong because of offset in bl_cmd, this may corrupt the stack which may cause a crash. Tested-by: Ferruh Yigit <fery@cypress.com> on TMA300-DVK Signed-off-by: Ferruh Yigit <fery@cypress.com> Acked-by: Javier Martinez Canillas <javier@dowhile0.org> Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input')
-rw-r--r--drivers/input/touchscreen/cyttsp_core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/input/touchscreen/cyttsp_core.c b/drivers/input/touchscreen/cyttsp_core.c
index 8e60437..97ba891 100644
--- a/drivers/input/touchscreen/cyttsp_core.c
+++ b/drivers/input/touchscreen/cyttsp_core.c
@@ -133,7 +133,7 @@ static int cyttsp_exit_bl_mode(struct cyttsp *ts)
memcpy(bl_cmd, bl_command, sizeof(bl_command));
if (ts->pdata->bl_keys)
memcpy(&bl_cmd[sizeof(bl_command) - CY_NUM_BL_KEYS],
- ts->pdata->bl_keys, sizeof(bl_command));
+ ts->pdata->bl_keys, CY_NUM_BL_KEYS);
error = ttsp_write_block_data(ts, CY_REG_BASE,
sizeof(bl_cmd), bl_cmd);
OpenPOWER on IntegriCloud