summaryrefslogtreecommitdiffstats
path: root/drivers/input
diff options
context:
space:
mode:
authorLuis Ortega <luiorpe1@upv.es>2014-01-27 12:27:49 -0800
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2014-01-27 22:35:17 -0800
commit5aee41a60c4d53f65918c1ec0ab94c245f2c08af (patch)
tree621414d35c644bbed2d75a02f490dda9d55f0b4d /drivers/input
parentad697b96e67dc34ef69e3358c331c69dcd283c0d (diff)
downloadop-kernel-dev-5aee41a60c4d53f65918c1ec0ab94c245f2c08af.zip
op-kernel-dev-5aee41a60c4d53f65918c1ec0ab94c245f2c08af.tar.gz
Input: zforce - remove unnecessary payload data checks
The function zforce_read_packet() reads 2 values (bytes) of payload header, validates them and then proceeds to read the payload body. The function stores all these in a u8 buffer. The PAYLOAD_LENGTH check seems to be trying to detect an overflow error. However, since we are just reading a u8 value from the buffer, these checks are unnecessary and we should simply compare against zero. Signed-off-by: Luis Ortega <luiorpe1@upv.es> Acked-by: Heiko Stuebner <heiko@sntech.de> Tested-by: Heiko Stuebner <heiko@sntech.de> - bq Cervantes (imx6sl) Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input')
-rw-r--r--drivers/input/touchscreen/zforce_ts.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/input/touchscreen/zforce_ts.c b/drivers/input/touchscreen/zforce_ts.c
index e87888c..3ed0249 100644
--- a/drivers/input/touchscreen/zforce_ts.c
+++ b/drivers/input/touchscreen/zforce_ts.c
@@ -423,7 +423,7 @@ static int zforce_read_packet(struct zforce_ts *ts, u8 *buf)
goto unlock;
}
- if (buf[PAYLOAD_LENGTH] <= 0 || buf[PAYLOAD_LENGTH] > 255) {
+ if (buf[PAYLOAD_LENGTH] == 0) {
dev_err(&client->dev, "invalid payload length: %d\n",
buf[PAYLOAD_LENGTH]);
ret = -EIO;
OpenPOWER on IntegriCloud