diff options
| author | Stephen Chandler Paul <cpaul@redhat.com> | 2015-07-15 10:20:17 -0700 |
|---|---|---|
| committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2015-07-16 10:30:55 -0700 |
| commit | e1443d2849b146be4ed8d4ef89ae7e215aafaa5b (patch) | |
| tree | 874ddd2d1c23d9bf46d2d751fe7c5764a3d18f4e /drivers/input/serio/i8042.h | |
| parent | 339d6b88e872f8369495a7224916a4d1d8376ca3 (diff) | |
| download | op-kernel-dev-e1443d2849b146be4ed8d4ef89ae7e215aafaa5b.zip op-kernel-dev-e1443d2849b146be4ed8d4ef89ae7e215aafaa5b.tar.gz | |
Input: i8042 - add unmask_kbd_data option
A big problem with the current i8042 debugging option is that it outputs
data going to and from the keyboard by default. As a result, many dmesg
logs uploaded by users will unintentionally contain sensitive information
such as their password, as such it's probably a good idea not to output
data coming from the keyboard unless specifically enabled by the user.
Signed-off-by: Stephen Chandler Paul <cpaul@redhat.com>
Reviewed-by: Andreas Mohr <andim2@users.sf.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input/serio/i8042.h')
| -rw-r--r-- | drivers/input/serio/i8042.h | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/drivers/input/serio/i8042.h b/drivers/input/serio/i8042.h index fc080be..1db0a40 100644 --- a/drivers/input/serio/i8042.h +++ b/drivers/input/serio/i8042.h @@ -73,6 +73,17 @@ static unsigned long i8042_start_time; printk(KERN_DEBUG KBUILD_MODNAME ": [%d] " format, \ (int) (jiffies - i8042_start_time), ##arg); \ } while (0) + +#define filter_dbg(filter, data, format, args...) \ + do { \ + if (!i8042_debug) \ + break; \ + \ + if (!filter || i8042_unmask_kbd_data) \ + dbg("%02x " format, data, ##args); \ + else \ + dbg("** " format, ##args); \ + } while (0) #else #define dbg_init() do { } while (0) #define dbg(format, arg...) \ @@ -80,6 +91,8 @@ static unsigned long i8042_start_time; if (0) \ printk(KERN_DEBUG pr_fmt(format), ##arg); \ } while (0) + +#define filter_dbg(filter, data, format, args...) do { } while (0) #endif #endif /* _I8042_H */ |
