summaryrefslogtreecommitdiffstats
path: root/drivers/input/serio/i8042.c
diff options
context:
space:
mode:
authorJiri Kosina <jkosina@suse.cz>2008-06-17 11:47:27 -0400
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2008-06-17 11:47:27 -0400
commit2f6a77d56523c14651236bc401a99b0e2aca2fdd (patch)
tree3697ee2c0525a6e4455327afcaaa7935c0d4dac0 /drivers/input/serio/i8042.c
parentefd5184646d5d400fc538d093e9a0bec22a75551 (diff)
downloadop-kernel-dev-2f6a77d56523c14651236bc401a99b0e2aca2fdd.zip
op-kernel-dev-2f6a77d56523c14651236bc401a99b0e2aca2fdd.tar.gz
Input: i8042 - retry failed CTR writes when resuming
There are systems that fail in i8042_resume() with i8042: Can't write CTR to resume as i8042_command(&i8042_ctr, I8042_CMD_CTL_WCTR) fails even though the controller claimed itself to be ready before. One retry after failing write fixes the problems on the failing systems. Reported-by: Helmut Schaa <hschaa@novell.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Diffstat (limited to 'drivers/input/serio/i8042.c')
-rw-r--r--drivers/input/serio/i8042.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
index 592ff55..170f71e 100644
--- a/drivers/input/serio/i8042.c
+++ b/drivers/input/serio/i8042.c
@@ -952,8 +952,12 @@ static int i8042_resume(struct platform_device *dev)
i8042_ctr |= I8042_CTR_AUXDIS | I8042_CTR_KBDDIS;
i8042_ctr &= ~(I8042_CTR_AUXINT | I8042_CTR_KBDINT);
if (i8042_command(&i8042_ctr, I8042_CMD_CTL_WCTR)) {
- printk(KERN_ERR "i8042: Can't write CTR to resume\n");
- return -EIO;
+ printk(KERN_WARNING "i8042: Can't write CTR to resume, retrying...\n");
+ msleep(50);
+ if (i8042_command(&i8042_ctr, I8042_CMD_CTL_WCTR)) {
+ printk(KERN_ERR "i8042: CTR write retry failed\n");
+ return -EIO;
+ }
}
OpenPOWER on IntegriCloud