diff options
| author | Roland Dreier <rolandd@cisco.com> | 2008-11-01 12:55:37 -0700 |
|---|---|---|
| committer | Roland Dreier <rolandd@cisco.com> | 2008-11-01 12:55:37 -0700 |
| commit | af2b0a1ec37c61513d83d2d123658b4ef69d2ce9 (patch) | |
| tree | c73156d136992126b02c742be730c396ca8f6ff6 /drivers/infiniband | |
| parent | 332edc2f7fa58b818dfed1cede60272eecc27c0a (diff) | |
| download | op-kernel-dev-af2b0a1ec37c61513d83d2d123658b4ef69d2ce9.zip op-kernel-dev-af2b0a1ec37c61513d83d2d123658b4ef69d2ce9.tar.gz | |
RDMA/cxgb3: Fix too-big reserved field zeroing in iwch_post_zb_read()
The array wqe->read.reserved has only two entries, but
iwch_post_zb_read() sets [0], [1], and [2], which is one too many.
This is harmless since it runs into the next field, rem_stag, which is
initialized correctly immediately after, but we might as well get
things right, especially since it makes the code smaller.
This was spotted by the Coverity checker (CID 2475).
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
Diffstat (limited to 'drivers/infiniband')
| -rw-r--r-- | drivers/infiniband/hw/cxgb3/iwch_qp.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/cxgb3/iwch_qp.c b/drivers/infiniband/hw/cxgb3/iwch_qp.c index 3e4585c..19661b2 100644 --- a/drivers/infiniband/hw/cxgb3/iwch_qp.c +++ b/drivers/infiniband/hw/cxgb3/iwch_qp.c @@ -745,7 +745,6 @@ int iwch_post_zb_read(struct iwch_qp *qhp) wqe->read.rdmaop = T3_READ_REQ; wqe->read.reserved[0] = 0; wqe->read.reserved[1] = 0; - wqe->read.reserved[2] = 0; wqe->read.rem_stag = cpu_to_be32(1); wqe->read.rem_to = cpu_to_be64(1); wqe->read.local_stag = cpu_to_be32(1); |
