diff options
| author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2007-01-25 22:35:47 +0100 |
|---|---|---|
| committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2007-02-08 20:59:54 +0100 |
| commit | beb2fdcad14af14fa38d5098003bd0f53e1c1185 (patch) | |
| tree | 031091f1600cd5e800cd7b527201deb6dd205b48 /drivers/ieee1394 | |
| parent | 9c31b387234287917023e64d1f11aedfd2685dd9 (diff) | |
| download | op-kernel-dev-beb2fdcad14af14fa38d5098003bd0f53e1c1185.zip op-kernel-dev-beb2fdcad14af14fa38d5098003bd0f53e1c1185.tar.gz | |
ieee1394: sbp2: lower block queue alignment requirement
The old setting is copy & waste from usb-storage and doesn't apply to
sbp2. There is only 4-byte alignment required for everything, except
for S/G table elements which have to be 8-byte aligned according to the
SBP-2 spec. (They happen to be ____cacheline_aligned in our
implementation. Whether that's good is another question.)
We now simply don't tune block queue alignment at all. The default
alignment would surely never become anything else than a multiple of 4,
else tons of calls to blk_queue_dma_alignment would have to be added
everywhere in drivers/...
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/ieee1394')
| -rw-r--r-- | drivers/ieee1394/sbp2.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c index 36d7b06..4edfff4 100644 --- a/drivers/ieee1394/sbp2.c +++ b/drivers/ieee1394/sbp2.c @@ -51,7 +51,6 @@ * Grep for inline FIXME comments below. */ -#include <linux/blkdev.h> #include <linux/compiler.h> #include <linux/delay.h> #include <linux/device.h> @@ -2012,7 +2011,6 @@ static int sbp2scsi_slave_configure(struct scsi_device *sdev) { struct sbp2_lu *lu = (struct sbp2_lu *)sdev->host->hostdata[0]; - blk_queue_dma_alignment(sdev->request_queue, (512 - 1)); sdev->use_10_for_rw = 1; if (sdev->type == TYPE_ROM) |
