summaryrefslogtreecommitdiffstats
path: root/drivers/ieee1394
diff options
context:
space:
mode:
authorSatyam Sharma <satyam@infradead.org>2007-08-15 20:05:38 +0530
committerStefan Richter <stefanr@s5r6.in-berlin.de>2007-10-16 23:59:56 +0200
commit69e2b602966533256edce1ed1b24fec23fe05962 (patch)
treeeba525129823949846660d6253a145fe211636a3 /drivers/ieee1394
parent261b5f664c6c68c5209656a71c41823eda0d938b (diff)
downloadop-kernel-dev-69e2b602966533256edce1ed1b24fec23fe05962.zip
op-kernel-dev-69e2b602966533256edce1ed1b24fec23fe05962.tar.gz
ieee1394: Fix kthread stopping in nodemgr_host_thread
The nodemgr host thread can exit on its own even when kthread_should_stop is not true, on receiving a signal (might never happen in practice, as it ignores signals). But considering kthread_stop() must not be mixed with kthreads that can exit on their own, I think changing the code like this is clearer. This change means the thread can cut its sleep short when receive a signal but looking at the code around, that sounds okay (and again, it might never actually recieve a signal in practice). Signed-off-by: Satyam Sharma <satyam@infradead.org> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/ieee1394')
-rw-r--r--drivers/ieee1394/nodemgr.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/ieee1394/nodemgr.c b/drivers/ieee1394/nodemgr.c
index 1939fee..11712a3 100644
--- a/drivers/ieee1394/nodemgr.c
+++ b/drivers/ieee1394/nodemgr.c
@@ -1712,7 +1712,8 @@ static int nodemgr_host_thread(void *__hi)
* to make sure things settle down. */
g = get_hpsb_generation(host);
for (i = 0; i < 4 ; i++) {
- if (msleep_interruptible(63) || kthread_should_stop())
+ msleep_interruptible(63);
+ if (kthread_should_stop())
goto exit;
/* Now get the generation in which the node ID's we collect
OpenPOWER on IntegriCloud