summaryrefslogtreecommitdiffstats
path: root/drivers/ieee1394
diff options
context:
space:
mode:
authorAl Viro <viro@ftp.linux.org.uk>2007-07-15 20:59:51 +0100
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-07-15 16:40:51 -0700
commit51ec138c6416e9ed2ba0eae3af5f0ea8a90ae44b (patch)
tree4c451864585014378922e16761be0a5225455166 /drivers/ieee1394
parent0e81c666dbf95546b3d9ea6ff7d29ea19b988950 (diff)
downloadop-kernel-dev-51ec138c6416e9ed2ba0eae3af5f0ea8a90ae44b.zip
op-kernel-dev-51ec138c6416e9ed2ba0eae3af5f0ea8a90ae44b.tar.gz
ieee1394: forgotten dereference...
Going through the string and waiting for _pointer_ to become '\0' is not what the authors meant... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Acked-by: Ben Collins <ben.collins@ubuntu.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/ieee1394')
-rw-r--r--drivers/ieee1394/nodemgr.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ieee1394/nodemgr.c b/drivers/ieee1394/nodemgr.c
index c4d3d41..51a1206 100644
--- a/drivers/ieee1394/nodemgr.c
+++ b/drivers/ieee1394/nodemgr.c
@@ -283,7 +283,7 @@ static ssize_t fw_show_##class##_##td_kv (struct device *dev, struct device_attr
memcpy(buf, \
CSR1212_TEXTUAL_DESCRIPTOR_LEAF_DATA(class->td_kv), \
len); \
- while ((buf + len - 1) == '\0') \
+ while (buf[len - 1] == '\0') \
len--; \
buf[len++] = '\n'; \
buf[len] = '\0'; \
OpenPOWER on IntegriCloud