diff options
| author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2005-12-13 11:05:03 -0500 |
|---|---|---|
| committer | Jody McIntyre <scjody@modernduck.com> | 2005-12-13 11:05:03 -0500 |
| commit | cf8d2c0965b891a5efce8c3a9a07a522e91ddba2 (patch) | |
| tree | 76786d162a6ad96f6f788c315223c47a5e10adee /drivers/ieee1394/sbp2.h | |
| parent | 209171a17a908605e516d11436371337a5d87f06 (diff) | |
| download | op-kernel-dev-cf8d2c0965b891a5efce8c3a9a07a522e91ddba2.zip op-kernel-dev-cf8d2c0965b891a5efce8c3a9a07a522e91ddba2.tar.gz | |
sbp2: split sbp2_create_command_orb() for better readability
sbp2_create_command_orb() code cleanup:
- add two helper functions to reduce nesting depth
- omit the return value which was always ignored
- remove unnecessary declaration from sb2.h
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Jody McIntyre <scjody@modernduck.com>
Diffstat (limited to 'drivers/ieee1394/sbp2.h')
| -rw-r--r-- | drivers/ieee1394/sbp2.h | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/ieee1394/sbp2.h b/drivers/ieee1394/sbp2.h index 8e227c5..900ea1d 100644 --- a/drivers/ieee1394/sbp2.h +++ b/drivers/ieee1394/sbp2.h @@ -410,13 +410,6 @@ static int sbp2_logout_device(struct scsi_id_instance_data *scsi_id); static int sbp2_handle_status_write(struct hpsb_host *host, int nodeid, int destid, quadlet_t *data, u64 addr, size_t length, u16 flags); static int sbp2_agent_reset(struct scsi_id_instance_data *scsi_id, int wait); -static int sbp2_create_command_orb(struct scsi_id_instance_data *scsi_id, - struct sbp2_command_info *command, - unchar *scsi_cmd, - unsigned int scsi_use_sg, - unsigned int scsi_request_bufflen, - void *scsi_request_buffer, - enum dma_data_direction dma_dir); static int sbp2_link_orb_command(struct scsi_id_instance_data *scsi_id, struct sbp2_command_info *command); static int sbp2_send_command(struct scsi_id_instance_data *scsi_id, |
