diff options
| author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2008-08-16 13:36:47 +0200 |
|---|---|---|
| committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2008-08-19 18:47:55 +0200 |
| commit | 6848408abf1bc18d9a4d5fed3fcca812745ece05 (patch) | |
| tree | cc52f981e49461426bc747821d0c133de20d7134 /drivers/ieee1394/nodemgr.h | |
| parent | 1fca25427482387689fa27594c992a961d98768f (diff) | |
| download | op-kernel-dev-6848408abf1bc18d9a4d5fed3fcca812745ece05.zip op-kernel-dev-6848408abf1bc18d9a4d5fed3fcca812745ece05.tar.gz | |
ieee1394: regression in 2.6.25: updates should happen before probes
Regression since commit 73cf60232ef16e1f8a64defa97214a1722db1e6c,
"ieee1394: use class iteration api": The two loops for (1.) driver
updates and (2.) driver probes were replaced by a single loop with
bogus needs_probe checks. Hence updates and probes were now intermixed,
and especially sbp2 updates (reconnects) held up longer than necessary.
While we fix it, change the needs_probe flag to bool type for clarity.
Tested by Damien Benoist.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/ieee1394/nodemgr.h')
| -rw-r--r-- | drivers/ieee1394/nodemgr.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ieee1394/nodemgr.h b/drivers/ieee1394/nodemgr.h index 919e92e..6eb2646 100644 --- a/drivers/ieee1394/nodemgr.h +++ b/drivers/ieee1394/nodemgr.h @@ -97,7 +97,7 @@ struct node_entry { struct hpsb_host *host; /* Host this node is attached to */ nodeid_t nodeid; /* NodeID */ struct bus_options busopt; /* Bus Options */ - int needs_probe; + bool needs_probe; unsigned int generation; /* Synced with hpsb generation */ /* The following is read from the config rom */ |
