summaryrefslogtreecommitdiffstats
path: root/drivers/ide/ide-tape.c
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2009-04-19 07:00:41 +0900
committerJens Axboe <jens.axboe@oracle.com>2009-04-28 07:37:28 +0200
commit0de57fb93b1daaeaecb658a98b3299ae460c02e9 (patch)
tree619690c0244902c9d7879a309298b5ae20cfe2af /drivers/ide/ide-tape.c
parent924cec7789f65ab7f022256f6533ecba0747b5f3 (diff)
downloadop-kernel-dev-0de57fb93b1daaeaecb658a98b3299ae460c02e9.zip
op-kernel-dev-0de57fb93b1daaeaecb658a98b3299ae460c02e9.tar.gz
ide-tape: remove back-to-back REQUEST_SENSE detection
Impact: fix an oops which always triggers ide_tape_issue_pc() assumed drive->pc isn't NULL on invocation when checking for back-to-back request sense issues but drive->pc can be NULL and even when it's not NULL, it's not safe to dereference it once the previous command is complete because pc could have been freed or was on stack. Kill back-to-back REQUEST_SENSE detection. Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'drivers/ide/ide-tape.c')
-rw-r--r--drivers/ide/ide-tape.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index cb942a9..3a53e08 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -614,12 +614,6 @@ static ide_startstop_t ide_tape_issue_pc(ide_drive_t *drive,
{
idetape_tape_t *tape = drive->driver_data;
- if (drive->pc->c[0] == REQUEST_SENSE &&
- pc->c[0] == REQUEST_SENSE) {
- printk(KERN_ERR "ide-tape: possible ide-tape.c bug - "
- "Two request sense in serial were issued\n");
- }
-
if (drive->failed_pc == NULL && pc->c[0] != REQUEST_SENSE)
drive->failed_pc = pc;
OpenPOWER on IntegriCloud