diff options
author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-06-15 22:16:10 +0200 |
---|---|---|
committer | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | 2009-06-15 22:16:10 +0200 |
commit | 2c7eaa43c3bb7b3b9fe2051d17f308c1f0728c78 (patch) | |
tree | 1b359598ea212bf7036bcc018186e0a8f20ac5f4 /drivers/ide/ide-cd.c | |
parent | a9c415090710a108edcd81b3392b90396f190a9a (diff) | |
download | op-kernel-dev-2c7eaa43c3bb7b3b9fe2051d17f308c1f0728c78.zip op-kernel-dev-2c7eaa43c3bb7b3b9fe2051d17f308c1f0728c78.tar.gz |
ide: BUG() on unknown requests
Unsupported requests should be never handed down to device drivers
and the best thing we can do upon discovering such request inside
driver's ->do_request method is to just BUG().
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Diffstat (limited to 'drivers/ide/ide-cd.c')
-rw-r--r-- | drivers/ide/ide-cd.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index dcd7244..0b7645b 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -785,12 +785,8 @@ static ide_startstop_t ide_cd_do_request(ide_drive_t *drive, struct request *rq, /* right now this can only be a reset... */ uptodate = 1; goto out_end; - } else { - blk_dump_rq_flags(rq, DRV_NAME " bad flags"); - if (rq->errors == 0) - rq->errors = -EIO; - goto out_end; - } + } else + BUG(); /* prepare sense request for this command */ ide_prep_sense(drive, rq); |