summaryrefslogtreecommitdiffstats
path: root/drivers/i2c
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2014-08-08 12:07:42 +0200
committerWolfram Sang <wsa@the-dreams.de>2014-08-08 18:45:30 +0200
commitebba48b702ab11bbb76e357a7246bc2f19ad02bc (patch)
tree579c96710145ecd2cfafb7adec93edd00d1408b7 /drivers/i2c
parent9c5f7cad3acc69ce623d04d646950183a759949e (diff)
downloadop-kernel-dev-ebba48b702ab11bbb76e357a7246bc2f19ad02bc.zip
op-kernel-dev-ebba48b702ab11bbb76e357a7246bc2f19ad02bc.tar.gz
i2c: mpc: delete unneeded test before of_node_put
Of_node_put supports NULL as its argument, so the initial test is not necessary. Suggested by Uwe Kleine-König. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression e; @@ -if (e) of_node_put(e); // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Diffstat (limited to 'drivers/i2c')
-rw-r--r--drivers/i2c/busses/i2c-mpc.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index 6a32aa0..0edf630 100644
--- a/drivers/i2c/busses/i2c-mpc.c
+++ b/drivers/i2c/busses/i2c-mpc.c
@@ -341,8 +341,7 @@ static u32 mpc_i2c_get_sec_cfg_8xxx(void)
iounmap(reg);
}
}
- if (node)
- of_node_put(node);
+ of_node_put(node);
return val;
}
OpenPOWER on IntegriCloud