summaryrefslogtreecommitdiffstats
path: root/drivers/i2c/i2c-dev.c
diff options
context:
space:
mode:
authorAkinobu Mita <akinobu.mita@gmail.com>2006-12-10 21:21:33 +0100
committerJean Delvare <khali@arrakis.delvare>2006-12-10 21:21:33 +0100
commit3bacb36db01c7541ffea21d4ff39219e8b211a5c (patch)
tree52d89e1c11c22e75aabe37c5bbeeb6800e0e247c /drivers/i2c/i2c-dev.c
parent250d1bd3f4ed0b50d79b3ec81ccefbabb203f916 (diff)
downloadop-kernel-dev-3bacb36db01c7541ffea21d4ff39219e8b211a5c.zip
op-kernel-dev-3bacb36db01c7541ffea21d4ff39219e8b211a5c.tar.gz
i2c: Fix return value check in i2c-dev
device_create() returns error code as pointer on failures. This patch checks the return value of device_create() by using IS_ERR(). Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Cc: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Jean Delvare <khali@linux-fr.org>
Diffstat (limited to 'drivers/i2c/i2c-dev.c')
-rw-r--r--drivers/i2c/i2c-dev.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
index cf9381e..909428a 100644
--- a/drivers/i2c/i2c-dev.c
+++ b/drivers/i2c/i2c-dev.c
@@ -416,8 +416,8 @@ static int i2cdev_attach_adapter(struct i2c_adapter *adap)
i2c_dev->dev = device_create(i2c_dev_class, &adap->dev,
MKDEV(I2C_MAJOR, adap->nr),
"i2c-%d", adap->nr);
- if (!i2c_dev->dev) {
- res = -ENODEV;
+ if (IS_ERR(i2c_dev->dev)) {
+ res = PTR_ERR(i2c_dev->dev);
goto error;
}
res = device_create_file(i2c_dev->dev, &dev_attr_name);
OpenPOWER on IntegriCloud