summaryrefslogtreecommitdiffstats
path: root/drivers/hwtracing
diff options
context:
space:
mode:
authorMark Brown <broonie@kernel.org>2015-04-10 09:25:37 -0600
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-05-18 12:56:15 -0700
commitf5da7cb24b78f2398c80a3ba25438602a68fc3e4 (patch)
treea15ec43632c5e91ae8ab148c9a37f73e95e10bf2 /drivers/hwtracing
parentcc5454490b514a87ccf99fce7ee224cc95980d99 (diff)
downloadop-kernel-dev-f5da7cb24b78f2398c80a3ba25438602a68fc3e4.zip
op-kernel-dev-f5da7cb24b78f2398c80a3ba25438602a68fc3e4.tar.gz
coresight: etb10: Fix check for bogus buffer depth
We attempt to sanity check the buffer depth reported by the hardware by making sure it is not less than zero however this check will never be true since the buffer depth is stored in an unsigned integer. Instead change the check to look for the top bit being set which was the intention. Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hwtracing')
-rw-r--r--drivers/hwtracing/coresight/coresight-etb10.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c
index 46eb9f8..2a77d83 100644
--- a/drivers/hwtracing/coresight/coresight-etb10.c
+++ b/drivers/hwtracing/coresight/coresight-etb10.c
@@ -457,7 +457,7 @@ static int etb_probe(struct amba_device *adev, const struct amba_id *id)
drvdata->buffer_depth = etb_get_buffer_depth(drvdata);
clk_disable_unprepare(drvdata->clk);
- if (drvdata->buffer_depth < 0)
+ if (drvdata->buffer_depth & 0x80000000)
return -EINVAL;
drvdata->buf = devm_kzalloc(dev,
OpenPOWER on IntegriCloud