summaryrefslogtreecommitdiffstats
path: root/drivers/hwmon
diff options
context:
space:
mode:
authorGuenter Roeck <linux@roeck-us.net>2015-03-27 06:03:41 -0700
committerGuenter Roeck <linux@roeck-us.net>2015-03-30 08:12:16 -0700
commit1696d1deb05710f246f62e810034fb5d8d7713bd (patch)
treed32b34bc5cc06f09b64e5cd96c27fb6513256f36 /drivers/hwmon
parentfcaf57b67dd03314ade476b847f246ae377160a8 (diff)
downloadop-kernel-dev-1696d1deb05710f246f62e810034fb5d8d7713bd.zip
op-kernel-dev-1696d1deb05710f246f62e810034fb5d8d7713bd.tar.gz
hwmon: (it87) Fix pwm sysfs attribute removal
Detection if a pwm channel is supported was wrong on removal, causing the code to try removing non-existing sysfs attributes. That didn't matter much because sysfs attribute removal of non-existing files fails silently, and because the wrong evaluation always returned false, but should nevertheless be fixed. Reviewed-by: Jean Delvare <jdelvare@suse.de> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
-rw-r--r--drivers/hwmon/it87.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
index ab12dc2..81a43db 100644
--- a/drivers/hwmon/it87.c
+++ b/drivers/hwmon/it87.c
@@ -2079,7 +2079,7 @@ static void it87_remove_files(struct device *dev)
it87_attributes_fan_div[i]);
}
for (i = 0; i < 3; i++) {
- if (sio_data->skip_pwm & (1 << 0))
+ if (sio_data->skip_pwm & (1 << i))
continue;
sysfs_remove_group(&dev->kobj, &it87_group_pwm[i]);
if (has_old_autopwm(data))
OpenPOWER on IntegriCloud