summaryrefslogtreecommitdiffstats
path: root/drivers/hwmon
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@ingics.com>2014-08-02 13:36:38 +0800
committerGuenter Roeck <linux@roeck-us.net>2014-08-04 07:27:50 -0700
commit2565fb05d1e9fc0831f7b1c083bcfcb1cba1f020 (patch)
treea4a81cb708b06dc65da7d38ffc3ff0a4050ef858 /drivers/hwmon
parent18d03f3cbd229ad9b03e12335ea066461fc00c73 (diff)
downloadop-kernel-dev-2565fb05d1e9fc0831f7b1c083bcfcb1cba1f020.zip
op-kernel-dev-2565fb05d1e9fc0831f7b1c083bcfcb1cba1f020.tar.gz
hwmon: (gpio-fan) Prevent overflow problem when writing large limits
On platforms with sizeof(int) < sizeof(unsigned long), writing a rpm value larger than MAXINT will result in unpredictable limit values written to the chip. Avoid auto-conversion from unsigned long to int to fix the problem. Signed-off-by: Axel Lin <axel.lin@ingics.com> Cc: stable@vger.kernel.org Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
-rw-r--r--drivers/hwmon/gpio-fan.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c
index a43e5b0..4efa173 100644
--- a/drivers/hwmon/gpio-fan.c
+++ b/drivers/hwmon/gpio-fan.c
@@ -173,7 +173,7 @@ static int get_fan_speed_index(struct gpio_fan_data *fan_data)
return -ENODEV;
}
-static int rpm_to_speed_index(struct gpio_fan_data *fan_data, int rpm)
+static int rpm_to_speed_index(struct gpio_fan_data *fan_data, unsigned long rpm)
{
struct gpio_fan_speed *speed = fan_data->speed;
int i;
OpenPOWER on IntegriCloud