diff options
| author | Anton Vasilyev <vasilyev@ispras.ru> | 2017-08-10 19:46:32 +0300 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2017-08-13 08:24:08 -0700 |
| commit | 3be6bd690da0dafa55eb65279fb25297fcfe19d5 (patch) | |
| tree | 8334fcb24a1feafc8fbb7672e4cfc5a01d84c144 /drivers/hwmon | |
| parent | 7576750f036b5ec913aac2a165ce75ab3b7beee3 (diff) | |
| download | op-kernel-dev-3be6bd690da0dafa55eb65279fb25297fcfe19d5.zip op-kernel-dev-3be6bd690da0dafa55eb65279fb25297fcfe19d5.tar.gz | |
hwmon: (stts751) buffer overrun on wrong chip configuration
If stts751 hw by some reason reports conversion rate bigger then 9:
ret = i2c_smbus_read_byte_data(priv->client, STTS751_REG_RATE);
then dereferencing stts751_intervals[priv->interval] leads to buffer
overrun.
The patch adds sanity check for value stored on chip.
Found by Linux Driver Verification project (linuxtesting.org).
Fixes: 7f07ec0fa17a ("hwmon: new driver for ST stts751 thermal sensor")
Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/stts751.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/hwmon/stts751.c b/drivers/hwmon/stts751.c index d56251d..3f940fb 100644 --- a/drivers/hwmon/stts751.c +++ b/drivers/hwmon/stts751.c @@ -718,6 +718,10 @@ static int stts751_read_chip_config(struct stts751_priv *priv) ret = i2c_smbus_read_byte_data(priv->client, STTS751_REG_RATE); if (ret < 0) return ret; + if (ret >= ARRAY_SIZE(stts751_intervals)) { + dev_err(priv->dev, "Unrecognized conversion rate 0x%x\n", ret); + return -ENODEV; + } priv->interval = ret; ret = stts751_read_reg16(priv, &priv->event_max, |
