summaryrefslogtreecommitdiffstats
path: root/drivers/hwmon
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@ingics.com>2014-07-02 08:29:55 +0800
committerGuenter Roeck <linux@roeck-us.net>2014-07-03 09:45:17 -0700
commit1035a9e3e9c76b64a860a774f5b867d28d34acc2 (patch)
treeaa2be34ac6b4bdf39f41dadb4bba97848624dfe9 /drivers/hwmon
parentdf86754b746e9a0ff6f863f690b1c01d408e3cdc (diff)
downloadop-kernel-dev-1035a9e3e9c76b64a860a774f5b867d28d34acc2.zip
op-kernel-dev-1035a9e3e9c76b64a860a774f5b867d28d34acc2.tar.gz
hwmon: (adm1029) Ensure the fan_div cache is updated in set_fan_div
Writing to fanX_div does not clear the cache. As a result, reading from fanX_div may return the old value for up to two seconds after writing a new value. This patch ensures the fan_div cache is updated in set_fan_div(). Reported-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Axel Lin <axel.lin@ingics.com> Cc: stable@vger.kernel.org Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
-rw-r--r--drivers/hwmon/adm1029.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c
index 78339e8..2804571 100644
--- a/drivers/hwmon/adm1029.c
+++ b/drivers/hwmon/adm1029.c
@@ -232,6 +232,9 @@ static ssize_t set_fan_div(struct device *dev,
/* Update the value */
reg = (reg & 0x3F) | (val << 6);
+ /* Update the cache */
+ data->fan_div[attr->index] = reg;
+
/* Write value */
i2c_smbus_write_byte_data(client,
ADM1029_REG_FAN_DIV[attr->index], reg);
OpenPOWER on IntegriCloud