diff options
| author | Shubhrajyoti D <shubhrajyoti@ti.com> | 2010-10-28 20:31:44 +0200 |
|---|---|---|
| committer | Jean Delvare <khali@endymion.delvare> | 2010-10-28 20:31:44 +0200 |
| commit | e3cd9528af4d1fd404eefe16e52ae421f99a7817 (patch) | |
| tree | fe43f5a2ab475769ede0c639dd5823a8c6937bc4 /drivers/hwmon/lm75.c | |
| parent | c4f99a2b8fb4c564865f0037a2b7be690d4409f3 (diff) | |
| download | op-kernel-dev-e3cd9528af4d1fd404eefe16e52ae421f99a7817.zip op-kernel-dev-e3cd9528af4d1fd404eefe16e52ae421f99a7817.tar.gz | |
hwmon: (lm75) Make the writing to sysfs more robust
Currently we get the checkpatch warning
consider using strict_strtol in preference to simple_strtol.
Also we should not allow any partially numeric values.
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Diffstat (limited to 'drivers/hwmon/lm75.c')
| -rw-r--r-- | drivers/hwmon/lm75.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c index ab5b87a..5cb79d9 100644 --- a/drivers/hwmon/lm75.c +++ b/drivers/hwmon/lm75.c @@ -103,7 +103,12 @@ static ssize_t set_temp(struct device *dev, struct device_attribute *da, struct i2c_client *client = to_i2c_client(dev); struct lm75_data *data = i2c_get_clientdata(client); int nr = attr->index; - long temp = simple_strtol(buf, NULL, 10); + long temp; + int error; + + error = strict_strtol(buf, 10, &temp); + if (error) + return error; mutex_lock(&data->update_lock); data->temp[nr] = LM75_TEMP_TO_REG(temp); |
