diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2014-02-11 21:34:21 -0800 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2014-03-03 08:01:04 -0800 |
| commit | 9bf3babf3f6e70723528bece564c57d38d534652 (patch) | |
| tree | ef59f7be88d0ad496ce238fee094cf1849e6a7ba /drivers/hwmon/emc2103.c | |
| parent | f44e5c5cf9303daac57be0aa01bc0e8f29f1b9bd (diff) | |
| download | op-kernel-dev-9bf3babf3f6e70723528bece564c57d38d534652.zip op-kernel-dev-9bf3babf3f6e70723528bece564c57d38d534652.tar.gz | |
hwmon: (emc2103) Return error from i2c_smbus_read_byte_data
There is no reason to replace one error with another.
smatch message:
drivers/hwmon/emc2103.c:352 set_fan_div() info: why not propagate 'status'
from i2c_smbus_read_byte_data() instead of (-5)?
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/emc2103.c')
| -rw-r--r-- | drivers/hwmon/emc2103.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/emc2103.c b/drivers/hwmon/emc2103.c index 2c137b2..fd892dd 100644 --- a/drivers/hwmon/emc2103.c +++ b/drivers/hwmon/emc2103.c @@ -349,7 +349,7 @@ static ssize_t set_fan_div(struct device *dev, struct device_attribute *da, dev_dbg(&client->dev, "reg 0x%02x, err %d\n", REG_FAN_CONF1, status); mutex_unlock(&data->update_lock); - return -EIO; + return status; } status &= 0x9F; status |= (new_range_bits << 5); |
