summaryrefslogtreecommitdiffstats
path: root/drivers/hid
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2015-09-18 16:31:33 -0700
committerJiri Kosina <jkosina@suse.cz>2015-09-23 14:08:35 +0200
commit79b568b9d0c7c5d81932f4486d50b38efdd6da6d (patch)
tree4b32fb032a341706cde7f365485837dee1c78c34 /drivers/hid
parent9fe8eccad4425fd024516fac2ebc0a39610441a0 (diff)
downloadop-kernel-dev-79b568b9d0c7c5d81932f4486d50b38efdd6da6d.zip
op-kernel-dev-79b568b9d0c7c5d81932f4486d50b38efdd6da6d.tar.gz
HID: core: Avoid uninitialized buffer access
hid_connect adds various strings to the buffer but they're all conditional. You can find circumstances where nothing would be written to it but the kernel will still print the supposedly empty buffer with printk. This leads to corruption on the console/in the logs. Ensure buf is initialized to an empty string. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> [dvhart: Initialize string to "" rather than assign buf[0] = NULL;] Cc: Jiri Kosina <jikos@kernel.org> Cc: linux-input@vger.kernel.org Cc: stable@vger.kernel.org Signed-off-by: Darren Hart <dvhart@linux.intel.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
-rw-r--r--drivers/hid/hid-core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index bcd914a..4130685 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1611,7 +1611,7 @@ int hid_connect(struct hid_device *hdev, unsigned int connect_mask)
"Multi-Axis Controller"
};
const char *type, *bus;
- char buf[64];
+ char buf[64] = "";
unsigned int i;
int len;
int ret;
OpenPOWER on IntegriCloud