summaryrefslogtreecommitdiffstats
path: root/drivers/hid
diff options
context:
space:
mode:
authorJiri Kosina <jkosina@suse.cz>2013-06-19 23:52:11 +0200
committerJiri Kosina <jkosina@suse.cz>2013-06-19 23:54:10 +0200
commita688393bd3fb27690a77f7ae8607b4969039bac5 (patch)
treefa7eee196868401562ce1be8d00c07904752ad1a /drivers/hid
parent6f1891d01956cad406d2af8ed2e9cef6108bfc5e (diff)
downloadop-kernel-dev-a688393bd3fb27690a77f7ae8607b4969039bac5.zip
op-kernel-dev-a688393bd3fb27690a77f7ae8607b4969039bac5.tar.gz
HID: explain out-of-range check better
Extend the comment explaining the condition for discarding out-of-range values to clarify the cases in which devices don't provide any logical min/max. Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
-rw-r--r--drivers/hid/hid-input.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 82130cf..9aeca60 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -1042,7 +1042,11 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
/*
* Ignore out-of-range values as per HID specification,
- * section 5.10 and 6.2.25
+ * section 5.10 and 6.2.25.
+ *
+ * The logical_minimum < logical_maximum check is done so that we
+ * don't unintentionally discard values sent by devices which
+ * don't specify logical min and max.
*/
if ((field->flags & HID_MAIN_ITEM_VARIABLE) &&
(field->logical_minimum < field->logical_maximum) &&
OpenPOWER on IntegriCloud