summaryrefslogtreecommitdiffstats
path: root/drivers/hid
diff options
context:
space:
mode:
authorJiri Kosina <jkosina@suse.cz>2014-08-27 09:13:15 +0200
committerJiri Kosina <jkosina@suse.cz>2014-08-27 09:14:39 +0200
commit844817e47eef14141cf59b8d5ac08dd11c0a9189 (patch)
tree7b4fbe046727d187383cd8497bf7b14ce1139bb4 /drivers/hid
parentc54def7bd64d7c0b6993336abcffb8444795bf38 (diff)
downloadop-kernel-dev-844817e47eef14141cf59b8d5ac08dd11c0a9189.zip
op-kernel-dev-844817e47eef14141cf59b8d5ac08dd11c0a9189.tar.gz
HID: picolcd: sanity check report size in raw_event() callback
The report passed to us from transport driver could potentially be arbitrarily large, therefore we better sanity-check it so that raw_data that we hold in picolcd_pending structure are always kept within proper bounds. Cc: stable@vger.kernel.org Reported-by: Steven Vittitoe <scvitti@google.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
-rw-r--r--drivers/hid/hid-picolcd_core.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/hid/hid-picolcd_core.c b/drivers/hid/hid-picolcd_core.c
index acbb0210..020df3c 100644
--- a/drivers/hid/hid-picolcd_core.c
+++ b/drivers/hid/hid-picolcd_core.c
@@ -350,6 +350,12 @@ static int picolcd_raw_event(struct hid_device *hdev,
if (!data)
return 1;
+ if (size > 64) {
+ hid_warn(hdev, "invalid size value (%d) for picolcd raw event\n",
+ size);
+ return 0;
+ }
+
if (report->id == REPORT_KEY_STATE) {
if (data->input_keys)
ret = picolcd_raw_keypad(data, report, raw_data+1, size-1);
OpenPOWER on IntegriCloud