summaryrefslogtreecommitdiffstats
path: root/drivers/gpu
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2014-12-23 12:56:49 +0300
committerAlex Deucher <alexander.deucher@amd.com>2015-01-05 12:10:08 -0500
commitdd5a74f2f982193620cfa1ef609df1ee805781d4 (patch)
tree6ea42eebf713a63abc6f40492b512f54cba42d38 /drivers/gpu
parent02ae7af53a451a1b0a51022c4693f5b339133e79 (diff)
downloadop-kernel-dev-dd5a74f2f982193620cfa1ef609df1ee805781d4.zip
op-kernel-dev-dd5a74f2f982193620cfa1ef609df1ee805781d4.tar.gz
drm/radeon: integer underflow in radeon_cp_dispatch_texture()
The test: if (size > RADEON_MAX_TEXTURE_SIZE) { "size" is an integer and it's controled by the user so it can be negative and the test can underflow. Later we use "size" in: dwords = size / 4; ... RADEON_COPY_MT(buffer, data, (int)(dwords * sizeof(u32))); It causes memory corruption to copy a negative size buffer. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu')
-rw-r--r--drivers/gpu/drm/radeon/radeon_state.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/radeon/radeon_state.c b/drivers/gpu/drm/radeon/radeon_state.c
index 535403e..15aee72 100644
--- a/drivers/gpu/drm/radeon/radeon_state.c
+++ b/drivers/gpu/drm/radeon/radeon_state.c
@@ -1703,7 +1703,7 @@ static int radeon_cp_dispatch_texture(struct drm_device * dev,
u32 format;
u32 *buffer;
const u8 __user *data;
- int size, dwords, tex_width, blit_width, spitch;
+ unsigned int size, dwords, tex_width, blit_width, spitch;
u32 height;
int i;
u32 texpitch, microtile;
OpenPOWER on IntegriCloud