diff options
| author | Paul Walmsley <pwalmsley@nvidia.com> | 2013-12-09 18:00:12 -0800 |
|---|---|---|
| committer | Thierry Reding <treding@nvidia.com> | 2013-12-19 09:29:52 +0100 |
| commit | 23a0e27aacad6b97598dd6786f782e4b6dd86096 (patch) | |
| tree | be0145a2eca936ce171ca1d8f1fab1a91f4e7d4d /drivers/gpu/drm/tegra/hdmi.c | |
| parent | 8e0d788c6feeb13cbf312acaefa0e91cece0677b (diff) | |
| download | op-kernel-dev-23a0e27aacad6b97598dd6786f782e4b6dd86096.zip op-kernel-dev-23a0e27aacad6b97598dd6786f782e4b6dd86096.tar.gz | |
gpu: host1x: clk_round_rate() can return a zero upon error
Treat both negative and zero return values from clk_round_rate() as
errors. This is needed since subsequent patches will convert
clk_round_rate()'s return value to be an unsigned type, rather than a
signed type, since some clock sources can generate rates higher than
(2^31)-1 Hz.
Eventually, when calling clk_round_rate(), only a return value of zero
will be considered a error. All other values will be considered valid
rates. The comparison against values less than 0 is kept to preserve
the correct behavior in the meantime.
Signed-off-by: Paul Walmsley <pwalmsley@nvidia.com>
Cc: Mikko Perttunen <mperttunen@nvidia.com>
Cc: Arto Merilainen <amerilainen@nvidia.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Terje Bergström <tbergstrom@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Diffstat (limited to 'drivers/gpu/drm/tegra/hdmi.c')
| -rw-r--r-- | drivers/gpu/drm/tegra/hdmi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c index 7f6253e..0cfc94f 100644 --- a/drivers/gpu/drm/tegra/hdmi.c +++ b/drivers/gpu/drm/tegra/hdmi.c @@ -960,7 +960,7 @@ static int tegra_output_hdmi_check_mode(struct tegra_output *output, parent = clk_get_parent(hdmi->clk_parent); err = clk_round_rate(parent, pclk * 4); - if (err < 0) + if (err <= 0) *status = MODE_NOCLOCK; else *status = MODE_OK; |
