summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/msm/msm_fbdev.c
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-11-25 14:30:28 +0100
committerRob Clark <robdclark@gmail.com>2014-12-17 10:59:49 -0500
commit264f7d673fad394d8ed6b17fa9c16e2e62fa0c4e (patch)
treee5b22d679389552e587fcfdbde52131fce7ac102 /drivers/gpu/drm/msm/msm_fbdev.c
parent4e0cd68115620bc3236ff4e58e4c073948629b41 (diff)
downloadop-kernel-dev-264f7d673fad394d8ed6b17fa9c16e2e62fa0c4e.zip
op-kernel-dev-264f7d673fad394d8ed6b17fa9c16e2e62fa0c4e.tar.gz
drm/msm: Deletion of unnecessary checks before two function calls
The functions framebuffer_release() and vunmap() perform also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Reviewed-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Rob Clark <robdclark@gmail.com>
Diffstat (limited to 'drivers/gpu/drm/msm/msm_fbdev.c')
-rw-r--r--drivers/gpu/drm/msm/msm_fbdev.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
index 94d55e5..1f3af13 100644
--- a/drivers/gpu/drm/msm/msm_fbdev.c
+++ b/drivers/gpu/drm/msm/msm_fbdev.c
@@ -190,8 +190,7 @@ fail_unlock:
fail:
if (ret) {
- if (fbi)
- framebuffer_release(fbi);
+ framebuffer_release(fbi);
if (fb) {
drm_framebuffer_unregister_private(fb);
drm_framebuffer_remove(fb);
OpenPOWER on IntegriCloud