diff options
author | Archit Taneja <architt@codeaurora.org> | 2016-04-29 15:19:35 +0530 |
---|---|---|
committer | Rob Clark <robdclark@gmail.com> | 2016-05-08 10:22:17 -0400 |
commit | f377d59729e744122751977eb79b349d2e166095 (patch) | |
tree | 0c5b7ef36440951d2d566d9e800d5d89d9020ae6 /drivers/gpu/drm/msm/edp/edp_ctrl.c | |
parent | d6c925cada0d92e49c3473bc0a69ea3913fff905 (diff) | |
download | op-kernel-dev-f377d59729e744122751977eb79b349d2e166095.zip op-kernel-dev-f377d59729e744122751977eb79b349d2e166095.tar.gz |
drm/msm/dsi: Fix regulator API abuse
The voltage changing code in this driver is broken and should be
removed. The driver sets a single, exact voltage on probe. Unless
there is a very good reason for this (which should be documented in
comments) constraints like this need to be set via the machine
constraints, voltage setting in a driver is expected to be used in cases
where the voltage varies at runtime.
In addition client drivers should almost never be calling
regulator_can_set_voltage(), if the device needs to set a voltage it
needs to set the voltage and the regulator core will handle the case
where the regulator is fixed voltage. If the driver simply skips
setting the voltage if it doesn't have permission then it should just
not bother in the first place.
Originally authored by Mark Brown <broonie@kernel.org>
Remove the min/max voltage data entries per SoC managed by the driver.
These aren't needed as we don't try to set voltages any more. Mention in
comments the voltages that each regulator expects.
Signed-off-by: Archit Taneja <architt@codeaurora.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
Diffstat (limited to 'drivers/gpu/drm/msm/edp/edp_ctrl.c')
0 files changed, 0 insertions, 0 deletions