diff options
| author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-04-05 10:03:22 +0200 |
|---|---|---|
| committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-04-22 15:39:03 +0200 |
| commit | 36b347fb31e74075315a782809007b9192c486ea (patch) | |
| tree | a9b575a0245f9b93493c0c12e7baf65e6c0e054d /drivers/gpu/drm/mgag200 | |
| parent | a798c10faf62a505d24e5f6213fbaf904a39623f (diff) | |
| download | op-kernel-dev-36b347fb31e74075315a782809007b9192c486ea.zip op-kernel-dev-36b347fb31e74075315a782809007b9192c486ea.tar.gz | |
drm/mgag200: Remove unecessary NULL check in bo_unref
ttm_bo_unref unconditionally calls kref_put on it's argument, so the
thing can't be NULL without already causing Oopses.
Spotted by coverity.
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/mgag200')
| -rw-r--r-- | drivers/gpu/drm/mgag200/mgag200_main.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c index 26868e5..0722d18 100644 --- a/drivers/gpu/drm/mgag200/mgag200_main.c +++ b/drivers/gpu/drm/mgag200/mgag200_main.c @@ -322,9 +322,7 @@ static void mgag200_bo_unref(struct mgag200_bo **bo) tbo = &((*bo)->bo); ttm_bo_unref(&tbo); - if (tbo == NULL) - *bo = NULL; - + *bo = NULL; } void mgag200_gem_free_object(struct drm_gem_object *obj) |
