diff options
| author | Joonas Lahtinen <joonas.lahtinen@linux.intel.com> | 2017-02-08 15:12:09 +0200 |
|---|---|---|
| committer | Joonas Lahtinen <joonas.lahtinen@linux.intel.com> | 2017-02-08 17:22:00 +0200 |
| commit | 3c779a49bd7ce6c9ecc35a679f28f94fe3cfaeab (patch) | |
| tree | a2db24065313d5907e5179baad66ab3ef5948d33 /drivers/gpu/drm/i915/intel_device_info.c | |
| parent | 038c95a313e4ca954ee5ab8a0c7559a646b0f462 (diff) | |
| download | op-kernel-dev-3c779a49bd7ce6c9ecc35a679f28f94fe3cfaeab.zip op-kernel-dev-3c779a49bd7ce6c9ecc35a679f28f94fe3cfaeab.tar.gz | |
drm/i915: Avoid BIT(max) - 1 and use GENMASK(max - 1, 0)
"BIT(max) - 1" will overflow when max = 32, and GCC will complain.
We already have GENMASK for generating the mask, use it!
v2: Majestic off by one spotted (Chris)
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_device_info.c')
| -rw-r--r-- | drivers/gpu/drm/i915/intel_device_info.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c index fcf8181..0891cc0 100644 --- a/drivers/gpu/drm/i915/intel_device_info.c +++ b/drivers/gpu/drm/i915/intel_device_info.c @@ -234,7 +234,7 @@ static void broadwell_sseu_info_init(struct drm_i915_private *dev_priv) * The subslice disable field is global, i.e. it applies * to each of the enabled slices. */ - sseu->subslice_mask = BIT(ss_max) - 1; + sseu->subslice_mask = GENMASK(ss_max - 1, 0); sseu->subslice_mask &= ~((fuse2 & GEN8_F2_SS_DIS_MASK) >> GEN8_F2_SS_DIS_SHIFT); |
