summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915/gvt
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2017-04-13 22:48:28 +0300
committerZhenyu Wang <zhenyuw@linux.intel.com>2017-04-18 17:50:05 +0800
commitc821ee6d2bb4cfc9991bf285f53103cde9d3593a (patch)
tree6cbf86111841e1a988f5789dce28ebd2ebb70998 /drivers/gpu/drm/i915/gvt
parent5ad59bf0960b807f01cb6ef8c54f68b3476a1546 (diff)
downloadop-kernel-dev-c821ee6d2bb4cfc9991bf285f53103cde9d3593a.zip
op-kernel-dev-c821ee6d2bb4cfc9991bf285f53103cde9d3593a.tar.gz
drm/i915/gvt: fix a bounds check in ring_id_to_context_switch_event()
There are two bugs here. The && should be || and the > is off by one so it should be >= ARRAY_SIZE(). Fixes: 8453d674ae7e ("drm/i915/gvt: vGPU execlist virtualization") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Diffstat (limited to 'drivers/gpu/drm/i915/gvt')
-rw-r--r--drivers/gpu/drm/i915/gvt/execlist.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/gvt/execlist.c b/drivers/gpu/drm/i915/gvt/execlist.c
index d077ed9..dc9aef3 100644
--- a/drivers/gpu/drm/i915/gvt/execlist.c
+++ b/drivers/gpu/drm/i915/gvt/execlist.c
@@ -56,8 +56,8 @@ static int context_switch_events[] = {
static int ring_id_to_context_switch_event(int ring_id)
{
- if (WARN_ON(ring_id < RCS && ring_id >
- ARRAY_SIZE(context_switch_events)))
+ if (WARN_ON(ring_id < RCS ||
+ ring_id >= ARRAY_SIZE(context_switch_events)))
return -EINVAL;
return context_switch_events[ring_id];
OpenPOWER on IntegriCloud