summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i810
diff options
context:
space:
mode:
authorDaniel Vetter <daniel.vetter@ffwll.ch>2011-10-30 12:44:56 +0100
committerDaniel Vetter <daniel.vetter@ffwll.ch>2011-12-22 19:54:58 +0100
commit40c34d042dc2f8954d5f619f6348a8659a4b416f (patch)
treec488dd68c7b146adc0e1de4f870208b9427ad42f /drivers/gpu/drm/i810
parent87499ffdcb1c70f66988cd8febc4ead0ba2f9118 (diff)
downloadop-kernel-dev-40c34d042dc2f8954d5f619f6348a8659a4b416f.zip
op-kernel-dev-40c34d042dc2f8954d5f619f6348a8659a4b416f.tar.gz
drm/i810: don't acces hw regs in lastclose
i810 uses a userspace provided mmio map using the drm core map infrastructure. By the time we reach lastclose, this is all gone and our mmio_map pointer points at freed memory. Depending upon luck that still works, most often it just oopses. Aside: drm maps aren't refcounted, so userspace can essentially oops the kernel any time it wants to. Who cares. Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i810')
-rw-r--r--drivers/gpu/drm/i810/i810_dma.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i810/i810_dma.c b/drivers/gpu/drm/i810/i810_dma.c
index 6b73c3e..f7c17b2 100644
--- a/drivers/gpu/drm/i810/i810_dma.c
+++ b/drivers/gpu/drm/i810/i810_dma.c
@@ -222,8 +222,6 @@ static int i810_dma_cleanup(struct drm_device *dev)
pci_free_consistent(dev->pdev, PAGE_SIZE,
dev_priv->hw_status_page,
dev_priv->dma_status_page);
- /* Need to rewrite hardware status page */
- I810_WRITE(0x02080, 0x1ffff000);
}
kfree(dev->dev_private);
dev->dev_private = NULL;
OpenPOWER on IntegriCloud