diff options
| author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-04-05 10:10:51 +0200 |
|---|---|---|
| committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-04-22 15:39:08 +0200 |
| commit | eb649a614d3a2204825cc41f32a7ae79ff74da35 (patch) | |
| tree | ce6ad8ad1256ff6e8848ecb53d45c82655445f08 /drivers/gpu/drm/ast | |
| parent | 3d535eddf2b7fc93126aaf4e36c05fe751fb8c4b (diff) | |
| download | op-kernel-dev-eb649a614d3a2204825cc41f32a7ae79ff74da35.zip op-kernel-dev-eb649a614d3a2204825cc41f32a7ae79ff74da35.tar.gz | |
drm/ast: Remove unnecessary NULL check in bo_unref
ttm_bo_unref unconditionally calls kref_put on it's argument, so the
thing can't be NULL without already causing Oopses.
Spotted by coverity.
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/ast')
| -rw-r--r-- | drivers/gpu/drm/ast/ast_main.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c index 50535fd..38941a6 100644 --- a/drivers/gpu/drm/ast/ast_main.c +++ b/drivers/gpu/drm/ast/ast_main.c @@ -411,10 +411,9 @@ static void ast_bo_unref(struct ast_bo **bo) tbo = &((*bo)->bo); ttm_bo_unref(&tbo); - if (tbo == NULL) - *bo = NULL; - + *bo = NULL; } + void ast_gem_free_object(struct drm_gem_object *obj) { struct ast_bo *ast_bo = gem_to_ast_bo(obj); |
