diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2017-02-20 18:15:47 +0200 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2017-03-16 21:52:11 +0100 |
| commit | 4033d4a4f5236b01200010bf38928347af75d86e (patch) | |
| tree | 8c117424c99314bd39f4f104895222990dd41034 /drivers/gpio | |
| parent | 4ed55016d763325887461d43d0aec4010adcab65 (diff) | |
| download | op-kernel-dev-4033d4a4f5236b01200010bf38928347af75d86e.zip op-kernel-dev-4033d4a4f5236b01200010bf38928347af75d86e.tar.gz | |
gpio: of: Don't return 0 on dt_gpio_count()
It's unusual to have error checking like (ret <= 0) in cases when
counting GPIO resources. In case when it's mandatory we propagate the
error (-ENOENT), otherwise we don't use the result.
This makes consistent behaviour across all possible variants called in
gpiod_count().
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio')
| -rw-r--r-- | drivers/gpio/gpiolib.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 530b1ba..c788b55 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -3122,10 +3122,10 @@ static int dt_gpio_count(struct device *dev, const char *con_id) gpio_suffixes[i]); ret = of_gpio_named_count(dev->of_node, propname); - if (ret >= 0) + if (ret > 0) break; } - return ret; + return ret ? ret : -ENOENT; } static int platform_gpio_count(struct device *dev, const char *con_id) |
