summaryrefslogtreecommitdiffstats
path: root/drivers/gpio/gpio-twl4030.c
diff options
context:
space:
mode:
authorAlexander Shiyan <shc_work@mail.ru>2014-03-22 12:32:15 +0400
committerLinus Walleij <linus.walleij@linaro.org>2014-03-27 10:06:34 +0100
commitfd0f885b79d1eac9b8aed7e04fe641b8cfd4ebf0 (patch)
tree345cb35a2e88832f23758aab9173628a8e8a8430 /drivers/gpio/gpio-twl4030.c
parenta54aef5072325ad3e5bd3e7c2858ae208fb4454d (diff)
downloadop-kernel-dev-fd0f885b79d1eac9b8aed7e04fe641b8cfd4ebf0.zip
op-kernel-dev-fd0f885b79d1eac9b8aed7e04fe641b8cfd4ebf0.tar.gz
gpio: twl4030: Remove redundant assignment
Variable "status" is never used, so remove it and add warning if any error happen. Signed-off-by: Alexander Shiyan <shc_work@mail.ru> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-twl4030.c')
-rw-r--r--drivers/gpio/gpio-twl4030.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpio/gpio-twl4030.c b/drivers/gpio/gpio-twl4030.c
index 8b88ca2..3ebb1a5 100644
--- a/drivers/gpio/gpio-twl4030.c
+++ b/drivers/gpio/gpio-twl4030.c
@@ -139,7 +139,6 @@ static u8 cached_leden;
static void twl4030_led_set_value(int led, int value)
{
u8 mask = LEDEN_LEDAON | LEDEN_LEDAPWM;
- int status;
if (led)
mask <<= 1;
@@ -148,8 +147,9 @@ static void twl4030_led_set_value(int led, int value)
cached_leden &= ~mask;
else
cached_leden |= mask;
- status = twl_i2c_write_u8(TWL4030_MODULE_LED, cached_leden,
- TWL4030_LED_LEDEN_REG);
+
+ WARN_ON_ONCE(twl_i2c_write_u8(TWL4030_MODULE_LED, cached_leden,
+ TWL4030_LED_LEDEN_REG));
}
static int twl4030_set_gpio_direction(int gpio, int is_input)
OpenPOWER on IntegriCloud