summaryrefslogtreecommitdiffstats
path: root/drivers/gpio/gpio-tc3589x.c
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2015-12-21 11:42:30 +0100
committerLinus Walleij <linus.walleij@linaro.org>2015-12-26 22:28:25 +0100
commit27ca226711d4bb438349fe0575660a60ad56b357 (patch)
tree6780577581717786927e597dddce2340b44aa159 /drivers/gpio/gpio-tc3589x.c
parentf2e13d2f6aaef281716db1fbe94ecb54fbfe5083 (diff)
downloadop-kernel-dev-27ca226711d4bb438349fe0575660a60ad56b357.zip
op-kernel-dev-27ca226711d4bb438349fe0575660a60ad56b357.tar.gz
gpio: tc3589x: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-tc3589x.c')
-rw-r--r--drivers/gpio/gpio-tc3589x.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c
index 7c1537e..2896aef 100644
--- a/drivers/gpio/gpio-tc3589x.c
+++ b/drivers/gpio/gpio-tc3589x.c
@@ -51,7 +51,7 @@ static int tc3589x_gpio_get(struct gpio_chip *chip, unsigned offset)
if (ret < 0)
return ret;
- return ret & mask;
+ return !!(ret & mask);
}
static void tc3589x_gpio_set(struct gpio_chip *chip, unsigned offset, int val)
OpenPOWER on IntegriCloud