diff options
| author | Vignesh R <vigneshr@ti.com> | 2016-06-09 11:02:04 +0530 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2016-06-13 09:21:28 +0200 |
| commit | a246b8198f776a16d1d3a3bbfc2d437bad766b29 (patch) | |
| tree | 706415a262cac9849cf7134e5831d9e4d31ba57d /drivers/gpio/gpio-pca953x.c | |
| parent | c0d30ecfe2f3e2254234d055982536fac18c7f1c (diff) | |
| download | op-kernel-dev-a246b8198f776a16d1d3a3bbfc2d437bad766b29.zip op-kernel-dev-a246b8198f776a16d1d3a3bbfc2d437bad766b29.tar.gz | |
gpio: pca953x: Fix NBANK calculation for PCA9536
NBANK() macro assumes that ngpios is a multiple of 8(BANK_SZ) and
hence results in 0 banks for PCA9536 which has just 4 gpios. This is
wrong as PCA9356 has 1 bank with 4 gpios. This results in uninitialized
PCA953X_INVERT register. Fix this by using DIV_ROUND_UP macro in
NBANK().
Cc: stable@vger.kernel.org
Signed-off-by: Vignesh R <vigneshr@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-pca953x.c')
| -rw-r--r-- | drivers/gpio/gpio-pca953x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 21b21cd..3969cc01 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -90,7 +90,7 @@ MODULE_DEVICE_TABLE(acpi, pca953x_acpi_ids); #define MAX_BANK 5 #define BANK_SZ 8 -#define NBANK(chip) (chip->gpio_chip.ngpio / BANK_SZ) +#define NBANK(chip) DIV_ROUND_UP(chip->gpio_chip.ngpio, BANK_SZ) struct pca953x_chip { unsigned gpio_start; |
