summaryrefslogtreecommitdiffstats
path: root/drivers/gpio/gpio-ich.c
diff options
context:
space:
mode:
authorJean Delvare <khali@linux-fr.org>2013-03-05 09:06:58 +0100
committerLinus Walleij <linus.walleij@linaro.org>2013-03-27 09:08:57 +0100
commit2ab3a749eb14c96eaf453afe6e678c9c1dab1637 (patch)
tree49f438a8d6e4107f4f061d3bc23a43b3a099d8f8 /drivers/gpio/gpio-ich.c
parenta937536b868b8369b98967929045f1df54234323 (diff)
downloadop-kernel-dev-2ab3a749eb14c96eaf453afe6e678c9c1dab1637.zip
op-kernel-dev-2ab3a749eb14c96eaf453afe6e678c9c1dab1637.tar.gz
gpio-ich: Fix value returned by ichx_gpio_request
Per Documentation/gpio.txt, gpio_request callbacks should return 0 on success or a negative value on error. So it is not clear what was meant by letting ichx_gpio_request return 1 in some cases, nor how a caller would interpret it. Align the code with the comment above it and consider pins as available by default. Signed-off-by: Jean Delvare <khali@linux-fr.org> Cc: Grant Likely <grant.likely@secretlab.ca> Acked-by: Peter Tyser <ptyser@xes-inc.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-ich.c')
-rw-r--r--drivers/gpio/gpio-ich.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c
index f9dbd50..de3c317 100644
--- a/drivers/gpio/gpio-ich.c
+++ b/drivers/gpio/gpio-ich.c
@@ -214,7 +214,7 @@ static int ichx_gpio_request(struct gpio_chip *chip, unsigned nr)
* If it can't be trusted, assume that the pin can be used as a GPIO.
*/
if (ichx_priv.desc->use_sel_ignore[nr / 32] & (1 << (nr & 0x1f)))
- return 1;
+ return 0;
return ichx_read_bit(GPIO_USE_SEL, nr) ? 0 : -ENODEV;
}
OpenPOWER on IntegriCloud