summaryrefslogtreecommitdiffstats
path: root/drivers/gpio/gpio-davinci.c
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2015-12-21 10:33:27 +0100
committerLinus Walleij <linus.walleij@linaro.org>2015-12-26 22:28:06 +0100
commit5b8d8fb0fc7412a4a7ec884b9d3b744aca2c462f (patch)
treeae360d0f97c528a408860c44d678467172cdd4a2 /drivers/gpio/gpio-davinci.c
parent1f66adfb5eb81428bc1a5700cffd22ba8e772272 (diff)
downloadop-kernel-dev-5b8d8fb0fc7412a4a7ec884b9d3b744aca2c462f.zip
op-kernel-dev-5b8d8fb0fc7412a4a7ec884b9d3b744aca2c462f.tar.gz
gpio: davinci: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Cc: Sekhar Nori <nsekhar@ti.com> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-davinci.c')
-rw-r--r--drivers/gpio/gpio-davinci.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 65ebaef..1e3a617e 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -125,7 +125,7 @@ static int davinci_gpio_get(struct gpio_chip *chip, unsigned offset)
struct davinci_gpio_controller *d = chip2controller(chip);
struct davinci_gpio_regs __iomem *g = d->regs;
- return (1 << offset) & readl_relaxed(&g->in_data);
+ return !!((1 << offset) & readl_relaxed(&g->in_data));
}
/*
OpenPOWER on IntegriCloud