summaryrefslogtreecommitdiffstats
path: root/drivers/firmware
diff options
context:
space:
mode:
authorThomas Meyer <thomas@m3y3r.de>2013-06-01 11:40:02 +0200
committerTony Luck <tony.luck@intel.com>2013-06-03 15:37:02 -0700
commit77418921649427577143667fcf00ccb8a809762a (patch)
tree330bcc094a773d292e93f4b5b60ed9ced7cb1524 /drivers/firmware
parentd683b96b072dc4680fc74964eca77e6a23d1fa6e (diff)
downloadop-kernel-dev-77418921649427577143667fcf00ccb8a809762a.zip
op-kernel-dev-77418921649427577143667fcf00ccb8a809762a.tar.gz
efi, pstore: Cocci spatch "memdup.spatch"
Change a kmalloc() + memcpy() pair for a single kmemdup() call. Signed-off-by: Thomas Meyer <thomas@m3y3r.de> Acked-by: Kees Cook <keescook@chromium.org> Signed-off-by: Tony Luck <tony.luck@intel.com>
Diffstat (limited to 'drivers/firmware')
-rw-r--r--drivers/firmware/efi/efi-pstore.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c
index 202d2c8..c692bb6 100644
--- a/drivers/firmware/efi/efi-pstore.c
+++ b/drivers/firmware/efi/efi-pstore.c
@@ -79,10 +79,9 @@ static int efi_pstore_read_func(struct efivar_entry *entry, void *data)
&entry->var.DataSize, entry->var.Data);
size = entry->var.DataSize;
- *cb_data->buf = kmalloc(size, GFP_KERNEL);
+ *cb_data->buf = kmemdup(entry->var.Data, size, GFP_KERNEL);
if (*cb_data->buf == NULL)
return -ENOMEM;
- memcpy(*cb_data->buf, entry->var.Data, size);
return size;
}
OpenPOWER on IntegriCloud