summaryrefslogtreecommitdiffstats
path: root/drivers/firmware
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2015-01-15 12:21:21 +0300
committerMatt Fleming <matt.fleming@intel.com>2015-01-20 15:50:25 +0000
commit86d68a58d00db3770735b5919ef2c6b12d7f06f3 (patch)
tree86c44e08c0682d84147ce93a82efc86fee8d014b /drivers/firmware
parent822a0279287603f150b991d0ea319bbba5aa235a (diff)
downloadop-kernel-dev-86d68a58d00db3770735b5919ef2c6b12d7f06f3.zip
op-kernel-dev-86d68a58d00db3770735b5919ef2c6b12d7f06f3.tar.gz
efi: Small leak on error in runtime map code
The "> 0" here should ">= 0" so we free map_entries[0]. Fixes: 926172d46038 ('efi: Export EFI runtime memory mapping to sysfs') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Dave Young <dyoung@redhat.com> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Diffstat (limited to 'drivers/firmware')
-rw-r--r--drivers/firmware/efi/runtime-map.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/efi/runtime-map.c b/drivers/firmware/efi/runtime-map.c
index 018c29a..87b8e3b 100644
--- a/drivers/firmware/efi/runtime-map.c
+++ b/drivers/firmware/efi/runtime-map.c
@@ -191,7 +191,7 @@ int __init efi_runtime_map_init(struct kobject *efi_kobj)
return 0;
out_add_entry:
- for (j = i - 1; j > 0; j--) {
+ for (j = i - 1; j >= 0; j--) {
entry = *(map_entries + j);
kobject_put(&entry->kobj);
}
OpenPOWER on IntegriCloud