summaryrefslogtreecommitdiffstats
path: root/drivers/firmware
diff options
context:
space:
mode:
authorMatt Fleming <matt.fleming@intel.com>2013-01-11 13:30:46 +0000
committerMatt Fleming <matt.fleming@intel.com>2013-01-31 14:44:44 +0000
commit94a193fb7393a50625abd9ca21f8afea275a9f87 (patch)
tree3a2ae392ae294bc5f67da5f43f725819f8a1a913 /drivers/firmware
parentdeb94101c4fda22e152c2a311210cf09ae51adf6 (diff)
downloadop-kernel-dev-94a193fb7393a50625abd9ca21f8afea275a9f87.zip
op-kernel-dev-94a193fb7393a50625abd9ca21f8afea275a9f87.tar.gz
efivarfs: Use sizeof() instead of magic number
Instead of adding a magic 4 to the variable size, use sizeof() to make it explicitly clear what the quantity represents (the variable's attributes). CC: Jeremy Kerr <jeremy.kerr@canonical.com> Cc: Chun-Yi Lee <joeyli.kernel@gmail.com> Cc: Andy Whitcroft <apw@canonical.com> Reported-by: Lingzhu Xiang <lxiang@redhat.com> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Diffstat (limited to 'drivers/firmware')
-rw-r--r--drivers/firmware/efivars.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index f5596db..371c441 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/firmware/efivars.c
@@ -1076,7 +1076,7 @@ static int efivarfs_fill_super(struct super_block *sb, void *data, int silent)
mutex_lock(&inode->i_mutex);
inode->i_private = entry;
- i_size_write(inode, size+4);
+ i_size_write(inode, size + sizeof(entry->var.Attributes));
mutex_unlock(&inode->i_mutex);
d_add(dentry, inode);
}
OpenPOWER on IntegriCloud