summaryrefslogtreecommitdiffstats
path: root/drivers/firmware
diff options
context:
space:
mode:
authorMatt Fleming <matt.fleming@intel.com>2013-01-16 13:47:05 +0000
committerMatt Fleming <matt.fleming@intel.com>2013-01-18 09:43:44 +0000
commit1fa7e6958c5f82cc75c594e3ffaf73cc26fc94c1 (patch)
treedcf54e5649e6e31fef2939f21c4246b1f30585c4 /drivers/firmware
parentb8f2c21db390273c3eaf0e5308faeaeb1e233840 (diff)
downloadop-kernel-dev-1fa7e6958c5f82cc75c594e3ffaf73cc26fc94c1.zip
op-kernel-dev-1fa7e6958c5f82cc75c594e3ffaf73cc26fc94c1.tar.gz
efivarfs: Never return ENOENT from firmware
Files are created in efivarfs_create() before a corresponding variable is created in the firmware. This leads to users being able to read/write to the file without the variable existing in the firmware. Reading a non-existent variable currently returns -ENOENT, which is confusing because the file obviously *does* exist. Convert EFI_NOT_FOUND into -EIO which is the closest thing to "error while interacting with firmware", and should hopefully indicate to the caller that the variable is in some uninitialised state. Cc: Josh Boyer <jwboyer@redhat.com> Acked-by: Jeremy Kerr <jeremy.kerr@canonical.com> Cc: Lee, Chun-Yi <jlee@suse.com> Cc: Andy Whitcroft <apw@canonical.com> Reported-by: Lingzhu Xiang <lxiang@redhat.com> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Diffstat (limited to 'drivers/firmware')
-rw-r--r--drivers/firmware/efivars.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index fa9fa03..807dad4 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/firmware/efivars.c
@@ -674,7 +674,7 @@ static int efi_status_to_err(efi_status_t status)
err = -EACCES;
break;
case EFI_NOT_FOUND:
- err = -ENOENT;
+ err = -EIO;
break;
default:
err = -EINVAL;
OpenPOWER on IntegriCloud