summaryrefslogtreecommitdiffstats
path: root/drivers/firewire
diff options
context:
space:
mode:
authorStefan Richter <stefanr@s5r6.in-berlin.de>2009-10-14 20:37:36 +0200
committerStefan Richter <stefanr@s5r6.in-berlin.de>2009-10-31 11:40:51 +0100
commit5b189bf3633c3b73d4f08124a86f3e019953d412 (patch)
tree3ee30bdd7b5e086e903199f29903400c77a3ddfe /drivers/firewire
parentcb7c96da3651111efbe088fa12f9bed61836ea93 (diff)
downloadop-kernel-dev-5b189bf3633c3b73d4f08124a86f3e019953d412.zip
op-kernel-dev-5b189bf3633c3b73d4f08124a86f3e019953d412.tar.gz
firewire: core: WARN on wrong usage of core transaction functions
In the code path which creates request packets, clearly mark a switch branch which must never be reached with a WARN. In the code path which creates response packets, replace a BUG by a friendlier to debug WARN. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/firewire')
-rw-r--r--drivers/firewire/core-transaction.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/firewire/core-transaction.c b/drivers/firewire/core-transaction.c
index 203e642..66789c3 100644
--- a/drivers/firewire/core-transaction.c
+++ b/drivers/firewire/core-transaction.c
@@ -218,6 +218,9 @@ static void fw_fill_request(struct fw_packet *packet, int tcode, int tlabel,
packet->header_length = 16;
packet->payload_length = 0;
break;
+
+ default:
+ WARN(1, KERN_ERR "wrong tcode %d", tcode);
}
common:
packet->speed = speed;
@@ -595,8 +598,7 @@ void fw_fill_response(struct fw_packet *response, u32 *request_header,
break;
default:
- BUG();
- return;
+ WARN(1, KERN_ERR "wrong tcode %d", tcode);
}
response->payload_bus = 0;
OpenPOWER on IntegriCloud