summaryrefslogtreecommitdiffstats
path: root/drivers/firewire/fw-topology.c
diff options
context:
space:
mode:
authorKristian Høgsberg <krh@redhat.com>2007-03-27 09:42:39 -0500
committerStefan Richter <stefanr@s5r6.in-berlin.de>2007-03-28 21:30:15 +0200
commit93e4fd455c62085cdceea3af4c56d95758d3cb74 (patch)
tree1b760e2a26572cf80c8a06d21cac3221582a4776 /drivers/firewire/fw-topology.c
parent3964a4496eaa4cb84772e8dfc6c3a72ec4ddca7a (diff)
downloadop-kernel-dev-93e4fd455c62085cdceea3af4c56d95758d3cb74.zip
op-kernel-dev-93e4fd455c62085cdceea3af4c56d95758d3cb74.tar.gz
firewire: Don't set card->irm_node before we have a new valid topology.
In case the topology build fails, we want to retain the old topology info until another reset finishes and results in a valid new tree. If we clear card->irm_node to NULL and the topology build fails, we end up dereferencing a NULL pointer in a few places. Signed-off-by: Kristian Høgsberg <krh@redhat.com> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/firewire/fw-topology.c')
-rw-r--r--drivers/firewire/fw-topology.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/firewire/fw-topology.c b/drivers/firewire/fw-topology.c
index 7923463..bc8a348 100644
--- a/drivers/firewire/fw-topology.c
+++ b/drivers/firewire/fw-topology.c
@@ -166,7 +166,7 @@ static void update_hop_count(struct fw_node *node)
static struct fw_node *build_tree(struct fw_card *card,
u32 *sid, int self_id_count)
{
- struct fw_node *node, *child, *local_node;
+ struct fw_node *node, *child, *local_node, *irm_node;
struct list_head stack, *h;
u32 *next_sid, *end, q;
int i, port_count, child_port_count, phy_id, parent_count, stack_depth;
@@ -178,7 +178,7 @@ static struct fw_node *build_tree(struct fw_card *card,
stack_depth = 0;
end = sid + self_id_count;
phy_id = 0;
- card->irm_node = NULL;
+ irm_node = NULL;
gap_count = self_id_gap_count(*sid);
topology_type = 0;
@@ -218,7 +218,7 @@ static struct fw_node *build_tree(struct fw_card *card,
local_node = node;
if (self_id_contender(q))
- card->irm_node = node;
+ irm_node = node;
if (node->phy_speed == SCODE_BETA)
topology_type |= FW_TOPOLOGY_B;
@@ -282,6 +282,7 @@ static struct fw_node *build_tree(struct fw_card *card,
}
card->root_node = node;
+ card->irm_node = irm_node;
card->gap_count = gap_count;
card->topology_type = topology_type;
OpenPOWER on IntegriCloud