summaryrefslogtreecommitdiffstats
path: root/drivers/extcon
diff options
context:
space:
mode:
authorMark Brown <broonie@opensource.wolfsonmicro.com>2013-04-01 19:18:18 +0100
committerMark Brown <broonie@opensource.wolfsonmicro.com>2013-04-02 11:54:05 +0100
commit41a57850b5e5c450da351465efcc41383def7f8a (patch)
tree99e49c35c4d9e65b09011eb6c6d23e78f1a30b97 /drivers/extcon
parent939c5671d11d86ae783f416b703c705647ac563b (diff)
downloadop-kernel-dev-41a57850b5e5c450da351465efcc41383def7f8a.zip
op-kernel-dev-41a57850b5e5c450da351465efcc41383def7f8a.tar.gz
extcon: arizona: Clear existing button reports before reporting new one
If the user moves directly from one button to another then we won't get a no buttons pressed event and will therefore end up reporting that two buttons are simultaneously pressed which isn't supported by the hardware. Make sure we clear any existing button reports before reporting any new ones. Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'drivers/extcon')
-rw-r--r--drivers/extcon/extcon-arizona.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index e2d881a..26f9a1a 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -852,6 +852,10 @@ static irqreturn_t arizona_micdet(int irq, void *data)
lvl = val & ARIZONA_MICD_LVL_MASK;
lvl >>= ARIZONA_MICD_LVL_SHIFT;
+ for (i = 0; i < info->num_micd_ranges; i++)
+ input_report_key(info->input,
+ info->micd_ranges[i].key, 0);
+
WARN_ON(!lvl);
WARN_ON(ffs(lvl) - 1 >= info->num_micd_ranges);
if (lvl && ffs(lvl) - 1 < info->num_micd_ranges) {
OpenPOWER on IntegriCloud