summaryrefslogtreecommitdiffstats
path: root/drivers/extcon
diff options
context:
space:
mode:
authorChanwoo Choi <cw00.choi@samsung.com>2016-07-18 15:39:28 +0900
committerChanwoo Choi <cw00.choi@samsung.com>2016-08-08 10:58:36 +0900
commit5d5321e90a69881a6e92604b73f7c8e8ca473373 (patch)
tree1daa641dd53683e0636ad2ff66169562d858c24b /drivers/extcon
parent7575591c2db8cbf4ba543cb9bcb6a4cdd5a7aa97 (diff)
downloadop-kernel-dev-5d5321e90a69881a6e92604b73f7c8e8ca473373.zip
op-kernel-dev-5d5321e90a69881a6e92604b73f7c8e8ca473373.tar.gz
extcon: Remove the state_store() to prevent the wrong access
This patch removes the state_store() which change the state of external connectors with bit masking on user-space. It is wrong access to modify the change the state of external connectors. Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Diffstat (limited to 'drivers/extcon')
-rw-r--r--drivers/extcon/extcon.c21
1 files changed, 1 insertions, 20 deletions
diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index 319659c..ad5e454 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -174,26 +174,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
return count;
}
-
-static ssize_t state_store(struct device *dev, struct device_attribute *attr,
- const char *buf, size_t count)
-{
- u32 state;
- ssize_t ret = 0;
- struct extcon_dev *edev = dev_get_drvdata(dev);
-
- ret = sscanf(buf, "0x%x", &state);
- if (ret == 0)
- ret = -EINVAL;
- else
- ret = extcon_set_state(edev, state);
-
- if (ret < 0)
- return ret;
-
- return count;
-}
-static DEVICE_ATTR_RW(state);
+static DEVICE_ATTR_RO(state);
static ssize_t name_show(struct device *dev, struct device_attribute *attr,
char *buf)
OpenPOWER on IntegriCloud