diff options
| author | Liviu Dudau <Liviu.Dudau@arm.com> | 2014-11-06 17:20:12 +0000 |
|---|---|---|
| committer | Vinod Koul <vinod.koul@intel.com> | 2014-11-17 13:01:22 +0530 |
| commit | 1f0a5cbf61a54504236bbbe2c98b58e85f90e650 (patch) | |
| tree | 5bb9b25cf26025e1c35124e5e3092acd0108050c /drivers/dma/pl330.c | |
| parent | c27f95568d1ed2573fc9c8848d741da63ca9a34e (diff) | |
| download | op-kernel-dev-1f0a5cbf61a54504236bbbe2c98b58e85f90e650.zip op-kernel-dev-1f0a5cbf61a54504236bbbe2c98b58e85f90e650.tar.gz | |
dmaengine: Fix allocation size for PL330 data buffer depth.
The datasheet for PL330 says that the data buffer value in the CRD
register is 10bits wide. However, the value stored is "minus one",
which the driver corrects for. Maximum value that the data buffer
depth can have is 1024 lines, which requires 11 bits for storage.
While making updates I found printing the peripheral ID as a hex
value to be more useful as the datasheet shows the values that way.
Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma/pl330.c')
| -rw-r--r-- | drivers/dma/pl330.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index e13b51a..19a9974 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -271,7 +271,7 @@ struct pl330_config { #define DMAC_MODE_NS (1 << 0) unsigned int mode; unsigned int data_bus_width:10; /* In number of bits */ - unsigned int data_buf_dep:10; + unsigned int data_buf_dep:11; unsigned int num_chan:4; unsigned int num_peri:6; u32 peri_ns; @@ -2741,7 +2741,7 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id) dev_info(&adev->dev, - "Loaded driver for PL330 DMAC-%d\n", adev->periphid); + "Loaded driver for PL330 DMAC-%x\n", adev->periphid); dev_info(&adev->dev, "\tDBUFF-%ux%ubytes Num_Chans-%u Num_Peri-%u Num_Events-%u\n", pcfg->data_buf_dep, pcfg->data_bus_width / 8, pcfg->num_chan, |
