diff options
| author | Vinod Koul <vinod.koul@intel.com> | 2014-07-25 15:39:50 +0530 |
|---|---|---|
| committer | Vinod Koul <vinod.koul@intel.com> | 2014-07-25 15:39:50 +0530 |
| commit | 37a746aaf5805c4bf3ab8f2d6e4cc78c879fd697 (patch) | |
| tree | df9a383091905f018f59ca845ea85048a5eb4240 /drivers/dma/ipu | |
| parent | e2f9922ad4526e747f9727a5481979727db56ec6 (diff) | |
| download | op-kernel-dev-37a746aaf5805c4bf3ab8f2d6e4cc78c879fd697.zip op-kernel-dev-37a746aaf5805c4bf3ab8f2d6e4cc78c879fd697.tar.gz | |
dmaengine: ipu: use return value of request_irq
Commit - 653e67f7e5: "dmaengine: inherit debug settings from the subsystem
for subdirectories" introduced debug option for subdirectories too
This exposed issue with ipu driver not using return value
For now just warn users about it
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma/ipu')
| -rw-r--r-- | drivers/dma/ipu/ipu_idmac.c | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c index 128ca14..bbf6292 100644 --- a/drivers/dma/ipu/ipu_idmac.c +++ b/drivers/dma/ipu/ipu_idmac.c @@ -1532,11 +1532,17 @@ static int idmac_alloc_chan_resources(struct dma_chan *chan) #ifdef DEBUG if (chan->chan_id == IDMAC_IC_7) { ic_sof = ipu_irq_map(69); - if (ic_sof > 0) - request_irq(ic_sof, ic_sof_irq, 0, "IC SOF", ichan); + if (ic_sof > 0) { + ret = request_irq(ic_sof, ic_sof_irq, 0, "IC SOF", ichan); + if (ret) + dev_err(&chan->dev->device, "request irq failed for IC SOF"); + } ic_eof = ipu_irq_map(70); - if (ic_eof > 0) - request_irq(ic_eof, ic_eof_irq, 0, "IC EOF", ichan); + if (ic_eof > 0) { + ret = request_irq(ic_eof, ic_eof_irq, 0, "IC EOF", ichan); + if (ret) + dev_err(&chan->dev->device, "request irq failed for IC EOF"); + } } #endif |
