summaryrefslogtreecommitdiffstats
path: root/drivers/crypto
diff options
context:
space:
mode:
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>2014-08-14 09:00:44 +0800
committerHerbert Xu <herbert@gondor.apana.org.au>2014-08-25 20:34:04 +0800
commit65fafbe9bddf49d53a2bbae92498909e3c5f964b (patch)
tree110a432d59abb22f14ec11234fd2bc4defac20bb /drivers/crypto
parente5ffbfc182bc148f44840bdd3970ea4c8bf80c3c (diff)
downloadop-kernel-dev-65fafbe9bddf49d53a2bbae92498909e3c5f964b.zip
op-kernel-dev-65fafbe9bddf49d53a2bbae92498909e3c5f964b.tar.gz
crypto: qat - Fix return value check in adf_chr_drv_create()
In case of error, the function device_create() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto')
-rw-r--r--drivers/crypto/qat/qat_common/adf_ctl_drv.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/crypto/qat/qat_common/adf_ctl_drv.c b/drivers/crypto/qat/qat_common/adf_ctl_drv.c
index d97069b..6f7816e 100644
--- a/drivers/crypto/qat/qat_common/adf_ctl_drv.c
+++ b/drivers/crypto/qat/qat_common/adf_ctl_drv.c
@@ -111,7 +111,7 @@ static int adf_chr_drv_create(void)
drv_device = device_create(adt_ctl_drv.drv_class, NULL,
MKDEV(adt_ctl_drv.major, 0),
NULL, DEVICE_NAME);
- if (!drv_device) {
+ if (IS_ERR(drv_device)) {
pr_err("QAT: failed to create device\n");
goto err_cdev_del;
}
OpenPOWER on IntegriCloud